Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate any metrics bits if prometheus is disabled #65

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Don't generate any metrics bits if prometheus is disabled #65

merged 1 commit into from
Oct 10, 2023

Conversation

rgrandl
Copy link
Collaborator

@rgrandl rgrandl commented Oct 10, 2023

No description provided.

@rgrandl
Don't generate any metrics bits if prometheus is disabled
4fa6e19 
If observability is completely disabled, we still add to the generated
k8s manifest file the metrics port on which we export metrics, and we
also create a label neede by prometheus to scrape the pods.

This PR disables generating such info unless prometheus is enabled.
@rgrandl rgrandl force-pushed the disable_prometheus_bits_in_kube_config branch from cb2d420 to 4fa6e19 Compare October 10, 2023 16:52
mwhittaker
mwhittaker approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@mwhittaker mwhittaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rgrandl rgrandl merged commit 579042f into main Oct 10, 2023
10 checks passed
@rgrandl rgrandl deleted the disable_prometheus_bits_in_kube_config branch October 10, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwhittaker mwhittaker mwhittaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgrandl @mwhittaker